lookit / lookit-api

Codebase for Lookit v2 and Experimenter v2. Includes an API. Docs: http://lookit.readthedocs.io/
https://lookit.mit.edu/
MIT License
10 stars 18 forks source link

Update study edit UI #1382

Closed okaycj closed 6 months ago

okaycj commented 6 months ago

Summary

The copy on a few study edit buttons was confusing. This PR changes that copy.

Closes #1378

Implementation

The card titles and buttons were updated as requested. The URL name attribute was also updated to reflect the copy.

Images

jsPsych study type:

Screenshot 2024-04-11 at 11 31 47 AM Screenshot 2024-04-11 at 11 31 56 AM Screenshot 2024-04-11 at 11 31 50 AM

Internal study type:

Screenshot 2024-04-11 at 11 31 13 AM Screenshot 2024-04-11 at 11 31 24 AM Screenshot 2024-04-11 at 11 31 17 AM

External study type:

Screenshot 2024-04-11 at 11 30 43 AM Screenshot 2024-04-11 at 11 30 56 AM Screenshot 2024-04-11 at 11 30 49 AM
sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ianchandlercampbell commented 6 months ago

If you can post screenshots of how it will look that would be helpful, but sounds like it looks good visually! It seems wise to change the researcher URLs and make sure internal and researcher facing labels are consistent. I can write a quick plaintext list of the how the urls are changing so we can tell users how to convert old links!

becky-gilbert commented 6 months ago

The URLs that are changing are all related to the "Edit Study Design" page (previously called "Study Details").

This URL just redirects users to the appropriate "Edit Study Design" page, depending on the study type:

"studies/\/study-details/" -> "studies/\/design/"

And here are the new URLs for the "Edit Study Design" page for each study type. The "study-details" part is now "design". (The jsPsych one is in there for us to use for testing, but not available for non-admin users yet).

"studies/\/study-details/efp/" -> "studies/\/design/efp/" "studies/\/study-details/external/" -> "studies/\/design/external/" "studies/\/study-details/jspsych/" -> "studies/\/design/jspsych/"

okaycj commented 6 months ago

@becky-gilbert

Thank you for putting together that list!

@ianchandlercampbell

The images you requested are up. Let me know if you want to see anything else.