lookit / lookit-api

Codebase for Lookit v2 and Experimenter v2. Includes an API. Docs: http://lookit.readthedocs.io/
https://lookit.mit.edu/
MIT License
10 stars 18 forks source link

Update child participation eligibility #1444

Closed okaycj closed 3 months ago

okaycj commented 3 months ago

Summary

Antidotally, the participation eligibility function was running slowly. This PR combines some queries within this function so that there are fewer calls to the database.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sentry-io[bot] commented 2 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

becky-gilbert commented 2 months ago

In case anyone else sees the Sentry error above - I think this was caused by doing a production release while the send_announcement_emails task was still running, hence the "closed the connection unexpectedly" error. So I think this is nothing to worry about. We will know for sure tomorrow after the announcement emails task has had the chance to run again.