search

lookit / lookit-docs

Documentation for Lookit project, including use of platform and lookit-api, ember-lookit-frameplayer, and exp-addons repos.
MIT License
2 stars 360 forks source link

Update docs about prior participation criteria (fixes #363) #365

Closed becky-gilbert closed 9 months ago

becky-gilbert commented 10 months ago

Fixes #363

docs1

docs2

docs3

docs4

docs5

docs6

mekline commented 10 months ago

Great! Only two possible issues I saw were:

mekline commented 10 months ago

Otherwise looks great to me!

becky-gilbert commented 10 months ago

Thanks @mekline!

There are two callout boxes for "What counts as participated", but I assume you only want the second one?

Ah, there's actually only one. It looks like there's two because of my overlapping screenshots. Here's what it looks like:

Screenshot 2023-11-20 at 3 44 33 PM

Could you also add this to the end of the first paragraph: "Since the definition for these criteria has to be used for every study on the site, we have to use a definition of "participated" that operates in the same way for all studies."

Yes, done! See screenshot above.

You mention an example in the EFP docs for using the protocol generator but I think there's a link missing.

Ah yes, sorry. I think this is because I've added a new section label to the EFP docs and the lookit docs won't be able to find that label until the EFP docs are changed on the master branch. So I think the missing link will appear once everything is merged. After merging I will check and fix it if not!

You also might want to explicitly say that you should not block the prerequisite study in the criteria, but then [EDIT, SORRY] use previous session logic during the beginning of the session to determine whether the family is really eligible.

Ah yes, makes sense. I tried to clarify this but struggled with the wording. My changes are shown in the screenshot above, 2nd paragraph from the bottom. Let me know if you have suggestions!

mekline commented 10 months ago

All looks great, thanks!