lookunder / RedmineHs

MIT License
2 stars 0 forks source link

Extend Redmine library to support non GET method. #3

Closed ywata closed 9 years ago

ywata commented 9 years ago

Hi. lookunder.

I'm trying to extend your RedmineHs library to support non GET method for post issues from my application. Before I create many code, I'd like you to review my code and update hackage code, if possible. I added some new APIs and moved some code, but I also tried to keep external API same as before. Thanks in advance.

Sample code for post an issue is implemented in Post.hs.

lookunder commented 9 years ago

I don't like putting the time parsing functions in their own module. I think they should stay hidden in the JSON module. They are an implementation detail. Do you have another use for them elsewhere?

ywata commented 9 years ago

Yes, I thought so. My application is reporting weekly report and I have to choose issues updated from starting time and end time of a period, the time are specified with command line argument. But I now agree with your argument, and considering UTCTime as an API, user can choose whatever format they like and you do not have to export them. That is OK for me.

ywata commented 9 years ago

Thanks!