search

lookyman / nette-oauth2-server-doctrine

Integration of The League of Extraordinary Packages' OAuth 2.0 Server into Nette Framework- Kdyby/Doctrine storage implementation
MIT License
13 stars 3 forks source link

Do not force string as return type of getUserIdentifier method #20

Closed Jigsik closed 4 years ago

Jigsik commented 4 years ago

We use majkl578/nette-identity-doctrine and identity->getId() returns int instead of string and thus method getUserIdentifier fails, because it expects string as return type.

I have inspected implemented interfaces and they expects string|int|null as return value, so I think forcing string as return type is not a good idea.

lookyman commented 4 years ago

Sure, no problem. Can you please fix the CI build?

Jigsik commented 4 years ago

Of course. I will let you know when it's done.

Jigsik commented 4 years ago

@lookyman Done. Thanks for merge.