search

loolabs / waterpark

Waterloo's social park
http://waterpark.loo-labs.vercel.app
ISC License
4 stars 0 forks source link

🗄 Add id fields to club's and event's domain & DTO definitions #135

Closed KTong821 closed 3 years ago

KTong821 commented 3 years ago

Purpose

This PR allows the backend to return unique ids for each object to the frontend that can then be used to query specific entities for more detail (yet to be implemented).

Also removes the ClubId and EventId value objects. these were found to be essentially wrappers around UniqueEntityID objects with little value but necessitated code such as club.id.id.toString().

Testing

Tests modified to account for new property; all tests pass.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/loo-labs/waterpark/AVvCcnRv1ENFyApjBjqeBbzfUvJM
✅ Preview: https://waterpark-git-update-id-fields-loo-labs.vercel.app