loolabs / waterpark

Waterloo's social park
http://waterpark.loo-labs.vercel.app
ISC License
4 stars 0 forks source link

🗄️ Add v2 entities to MikroORM over top of legacy v1 entities #181

Closed xujustinj closed 3 years ago

xujustinj commented 3 years ago

Co-authored by: @KTong821

Purpose

Describe the problem or feature in addition to a link to the issues.

Add v2 Mikro entities

Approach

We followed our designs from https://drive.google.com/file/d/1UyiFLpFQ3josOweJxdyGexvNFoepHtbL/view

Our implementation of the IS-A relations involving Places and Reviews will be entity-in-all-superclasses. This decision was made with @KTong821 after considering all 3 IS-A patterns. Because of this, we do not make use of MikroORM inheritance mapping.

Testing

How did you test your changes?

Unit tests pass (still attached to legacy entities)

Integration tests are broken, but we don't really care

TODOs for Future PRs

Learning

See MikroORM links posted in the Discord

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/loo-labs/waterpark/5kLaGbCYgzB19CbvG8Vk7pudCnYJ
✅ Preview: https://waterpark-git-v2-entities-loo-labs.vercel.app