Closed xujustinj closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/loo-labs/waterpark/4p1qzgBwoKrnfDwM9NioZZzrkv8n
✅ Preview: https://waterpark-git-cleanup-test-utils-loo-labs.vercel.app
Purpose
There are a lot of TODOs and problems in the
test-utils
folder, many which became apparent when doing #221.const identifier = (...) => { ... }
pattern for defining functions is confusing to new devs easing into Types. It also seems to go against Google's TS style guide.const identifier = ...; export { identifier }
pattern duplicates the identifier on two lines which may be far apart from one another. This means more confusing PRs. It also seems to go against Google's style guide.mocks/objects
mockHandlerParams
After this PR, I will change the remaining files where problems 1 and 2 appear.
Testing
Unit tests pass,
npm run build
compiles code successfully.