loomnetwork / erc721x

ERC721x is an extension of ERC721 that adds support for multi-fungible tokens and batch transfers, while being fully backward-compatible.
BSD 3-Clause "New" or "Revised" License
165 stars 54 forks source link

Interfaces/ERC721X.sol doesn't match implementation in Core #1

Closed enlight closed 6 years ago

enlight commented 6 years ago
./contracts/ERC721X/Core/ERC721XToken.sol:28:5: TypeError: Overriding function visibility differs.
    function implementsERC721X() public pure returns (bool) {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:5:3: Overriden function is here:
  function implementsERC721X() external pure returns (bool);
  ^--------------------------------------------------------^

,/contracts/ERC721X/Core/ERC721XTokenNFT.sol:80:5: TypeError: Overriding function visibility differs.
    function ownerOf(uint256 _tokenId) public view returns (address) {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:7:3: Overriden function is here:
  function ownerOf(uint256 _tokenId) external view returns (address _owner);
  ^------------------------------------------------------------------------^

openzeppelin-solidity/contracts/token/ERC721/ERC721Basic.sol:65:3: TypeError: Overriding function visibility differs.
  function ownerOf(uint256 _tokenId) public view returns (address _owner);
  ^----------------------------------------------------------------------^
./contracts/ERC721X/Interfaces/ERC721X.sol:7:3: Overriden function is here:
  function ownerOf(uint256 _tokenId) external view returns (address _owner);
  ^------------------------------------------------------------------------^

,/contracts/ERC721X/Core/ERC721XTokenNFT.sol:135:5: TypeError: Overriding function visibility differs.
    function balanceOf(address _address, uint256 _tokenId) public view returns (uint256) {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:8:3: Overriden function is here:
  function balanceOf(address owner, uint256 tokenId) external view returns (uint256);
  ^---------------------------------------------------------------------------------^

,/contracts/ERC721X/Core/ERC721XTokenNFT.sol:92:5: TypeError: Overriding function visibility differs.
    function tokensOwned(address _owner) public view returns (uint256[] indexes, uint256[] balances) {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:11:3: Overriden function is here:
  function tokensOwned(address owner) external view returns (uint256[]);
  ^--------------------------------------------------------------------^

,/contracts/ERC721X/Core/ERC721XToken.sol:133:5: TypeError: Overriding function visibility differs.
    function transfer(address _to, uint256 _tokenId, uint256 _amount) public {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:13:3: Overriden function is here:
  function transfer(address to, uint256 tokenId, uint256 quantity) external;
  ^------------------------------------------------------------------------^

,/contracts/ERC721X/Core/ERC721XToken.sol:137:5: TypeError: Overriding function visibility differs.
    function transferFrom(address _from, address _to, uint256 _tokenId, uint256 _amount) public {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:14:3: Overriden function is here:
  function transferFrom(address from, address to, uint256 tokenId, uint256 quantity) external;
  ^------------------------------------------------------------------------------------------^

,/contracts/ERC721X/Core/ERC721XToken.sol:168:5: TypeError: Overriding function visibility differs.
    function safeTransferFrom(address _from, address _to, uint256 _tokenId, uint256 _amount) public {
    ^ (Relevant source part starts here and spans across multiple lines).
./contracts/ERC721X/Interfaces/ERC721X.sol:17:3: Overriden function is here:
  function safeTransferFrom(address from, address to, uint256 tokenId, uint256 _amount) external;
  ^---------------------------------------------------------------------------------------------^