search

loomnetwork / erc721x

ERC721x is an extension of ERC721 that adds support for multi-fungible tokens and batch transfers, while being fully backward-compatible.
BSD 3-Clause "New" or "Revised" License
165 stars 54 forks source link

missing uint256 on objectBalance #12

Closed AlberErre closed 6 years ago

AlberErre commented 6 years ago

In case of "Operations.SUB", objectBalance type is not defined

gakonst commented 6 years ago

This actually compiles currently! https://twitter.com/gakonst/status/1041658852037541888

More context: https://www.youtube.com/watch?v=gk-Yu7BLa6I

contracts/Libraries/ObjectsLib.sol:54:9: DeclarationError: Identifier already declared.
        uint256 objectBalance = getValueInBin(_binBalances, _index);
        ^-------------------^

contracts/Libraries/ObjectsLib.sol:49:9: The previous declaration is here:
        uint256 objectBalance = getValueInBin(_binBalances, _index);
        ^-------------------^
Compilation failed. See above.

This is a duplicate definition if you try to define it again. Pls test before making PRs thanks:)