Bug with FT having an owner

loomnetwork / erc721x

ERC721x is an extension of ERC721 that adds support for multi-fungible tokens and batch transfers, while being fully backward-compatible.

BSD 3-Clause "New" or "Revised" License

165 stars 54 forks source link

Bug with FT having an owner #14

Closed wighawag closed 6 years ago

wighawag commented 6 years ago

With the latest version, ownerOf`(tokenId) throw when called on a FT tokenId. This is I think a sensible approach.

But the current implementation has a bug. If you transfer such FT via the standard ERC721 transfer method (without specifying quantity), the destination address to assigned to be the owner.

The result is that now the FT has an owner.

See PR : https://github.com/loomnetwork/erc721x/pull/13

gakonst commented 6 years ago

fixed in https://github.com/loomnetwork/erc721x/commit/81623613f31b44886588154201e3546e67e3db6b, thanks!