Closed Pongch closed 5 years ago
Yeah this is part of https://github.com/loomnetwork/erc721x/issues/10, tbd in the future as we abstract it from the core contract.
Fixed in https://github.com/loomnetwork/erc721x/commit/db5928ad03acdf2ecaa10db8ea8c0e754b6c716a, now the URI is passed via the constructor
Currently with how token URIs are implemented:
you are able to successfully mint a token with ID :
8999999
and check that it exists but by callingtokenURI()
of the token ID, it will return999999
(missing the 7th digit)There might be a better approach to this without having to manually specifying: '_uriBytes[38] = byte(48+(_tokenId / 100000) % 10);' Otherwise it might be ideal to revert the transaction if a user is attempting to mint tokens with more than 6 digits IDs