search

loomnetwork / erc721x

ERC721x is an extension of ERC721 that adds support for multi-fungible tokens and batch transfers, while being fully backward-compatible.
BSD 3-Clause "New" or "Revised" License
165 stars 54 forks source link

Don't allow re-minting / dilution of existing FTs #24

Closed jamesmartinduffy closed 5 years ago

jamesmartinduffy commented 5 years ago

Code currently allows minting of additional copies of existing FTs. Supply should be set once upon token creation, and dilution should not be possible.

gakonst commented 5 years ago

This is not required to be on the base contract. The mint function is internal which means they are going to be used by another contract which inherits from ERC721X. If desirable, the other contract will implement a mint function which can only be callable once

jamesmartinduffy commented 5 years ago

Yep, that makes sense — it should be up to the developer to determine if they want to allow re-minting or not.

Eventually we should add some examples to this repo of different fully fleshed out implementations with best practices, but will this for now.