search

loomnetwork / plasma-cash

Plasma Cash Contract & Client. ERC721, ERC20, and ETH compatible
https://loomx.io/developers
Other
271 stars 62 forks source link

Autolint python PEP8 #45

Closed gakonst closed 6 years ago

gakonst commented 6 years ago

Since we have a PR that enforces linting for a build to go through, I suggest that we use https://github.com/ambv/black as black --line-length 79 for our formatting reasons and https://github.com/timothycrosley/isort for import ordering, what do you think?

aupiff commented 6 years ago

Yeah those both sound good to me.

aupiff commented 6 years ago

By the way, I don't think import order is something our flake8 is setup to care about. Review our setup for in .flake8 to see if there's anything you'd like to change.

gakonst commented 6 years ago

I agree with it, suggested isort for styling reasons