QUESTION: does `send_transaction` need the `denomination` parameter?

loomnetwork / plasma-cash

Plasma Cash Contract & Client. ERC721, ERC20, and ETH compatible

https://loomx.io/developers

Other

271 stars 62 forks source link

Closed aupiff closed 6 years ago

aupiff commented 6 years ago

@gakonst

Why do we need a denomination parameter in the send_transaction function? Do we want to be be consistent with non-erc721 applications?

gakonst commented 6 years ago

Yes, it's there for doing more than just erc721, but let's remove it to make our code concise and specific to the usecase.

aupiff commented 6 years ago

OK, I'm getting rid of it on the branch I'm working on.