search

loomnetwork / unity-sdk

Loom DAppChain SDK for Unity3d
Other
121 stars 34 forks source link

Rename `Contract` to `PluginContract` #16

Closed ZimM-LostPolygon closed 6 years ago

ZimM-LostPolygon commented 6 years ago

Since we move from plugin-based contracts more towards EVM-based contracts, I think it makes sense to rename Contract into a more specific PluginContract, because otherwise it can be assumed that plugin-based contracts are some kind of "recommended default".

enlight commented 6 years ago

Not a big fan of the idea, it'd introduce inconsistency with the loom-js and go-loom APIs.

ZimM-LostPolygon commented 6 years ago

The same reasoning applies to other SDKs, so it can be a global change. For C# at least, we can keep Contract for a while to not break the public API, but emit a obsolescence warning if it is used.

On Wed, Jun 20, 2018, 16:48 Vadim Macagon notifications@github.com wrote:

Not a big fan of the idea, it'd introduce inconsistency with the loom-js and go-loom APIs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/loomnetwork/unity3d-sdk/issues/16#issuecomment-398778418, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4rJo0Hga4Ws3mU6cBM_P3kCjbi3hSJks5t-mC9gaJpZM4UvVbB .

enlight commented 6 years ago

Don't like the new name, and don't want to spend any more time on this.