loonghao / photoshop-python-api

Python API for Photoshop.

https://loonghao.github.io/photoshop-python-api/

MIT License

604 stars 68 forks source link

refactor(Photoshop,Application): Attempt to retrieve running Photoshop Application with GetActiveObject #262

Closed Investigamer closed 1 year ago

Investigamer commented 1 year ago

Changes Summary

When establishing the Photoshop Application object, attempt to retrieve a currently running Photoshop Application using GetActiveObject before spawning a new one with CreateObject.
Added caching for the conversion methods, such as charIDToTypeID, since results are static with low overhead. Improves execution time by a factor of ~400 on successive calls passing the same ID.
Corrected some typos and out of place empty lines

Investigamer commented 1 year ago

There's something strange going on with this ""Reorder Python Imports" hook, its taking the import comments "Third party modules" etc and forcing them to the bottom of the import list, even though isort places them how they are supposed to be. Not sure what exactly to do about that might be a bug with that hook. Just going to cause the tests to fail on formatting in perpetuity. I've attached examples of how it changes it:

Investigamer commented 1 year ago

Going to go back to the drawing board on this one because I just realized we are trying to maintain Python support going all the way back to 3.7 so I guess cache from functools is out of the question!