Implement the ability to have fixed y axis

loony-bean / textplots-rs

Terminal plotting library for Rust

238 stars 24 forks source link

Implement the ability to have fixed y axis #33

Closed TDHolmes closed 3 years ago

TDHolmes commented 3 years ago

Closes #32

https://user-images.githubusercontent.com/12289754/130336549-f7d8e10b-fc48-4208-93ba-2d7dc70b8111.mov

TDHolmes commented 3 years ago

Oh I didn't think of this at the time, but if you want I can update the CLI version to have optional y range. Sounds like #30 would benefit from it (this comment)

loony-bean commented 3 years ago

Yeah, I guess CLI should be updated as well. Also, any chance of adding your demo as example? It's so cool

TDHolmes commented 3 years ago

done!

TDHolmes commented 3 years ago

Also I'm open to naming suggestions for the new new method, if anyone has a better idea

loony-bean commented 3 years ago

I'm happy to merge this. I just wanted to merges this after https://github.com/loony-bean/textplots-rs/pull/34

Naming is not a big concern for me because we are in 0.x, and also I believe that at some point we will need to add ability to have non-fixed x axis as well. Maybe we'll refactor things a bit then.

loony-bean commented 3 years ago

Nice work @TDHolmes! Thanks 😍

ahcm commented 3 years ago

Thanks!