search

loony-bean / textplots-rs

Terminal plotting library for Rust
238 stars 24 forks source link

switch to GitHub Actions #34

Closed TDHolmes closed 3 years ago

TDHolmes commented 3 years ago

No worries if you want to stick with Travis for CI, but thought I'd throw it up to see what you thought. Since it's coming from a fork you won't see the CI running, but see this PR on my fork for what it'd look like for future PRs if you merged.

TDHolmes commented 3 years ago
loony-bean commented 3 years ago

This looks amazing! I'd love to switch to GA. One question though - do you use nightly toolchain to run checks?

TDHolmes commented 3 years ago

It currently uses nightly, but can be switched. See this line

loony-bean commented 3 years ago

Got it. Could we switch to stable please? since we are not using any nightly features.

Another thing I wanted to ask, if you could run all the examples in the CI. IMHO it will be a nice addition to tests, to make sure examples do no produce runtime errors.

TDHolmes commented 3 years ago

sure, but I'll have to change my live plot example to only run for a limited time. Maybe like ~5s?

On Mon, Aug 23, 2021 at 12:32 AM Alexey Suslov @.***> wrote:

Got it. Could we switch to stable please? since we are not using any nightly features.

Another thing I wanted to ask, if you could run all the examples in the CI. IMHO it will be a nice addition to tests, to make sure examples do no produce runtime errors.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/loony-bean/textplots-rs/pull/34#issuecomment-903516538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5YNWVDSOCCCJYKB32KWV3T6H2RDANCNFSM5CSJFKDQ .

loony-bean commented 3 years ago

5s is fine 👍

TDHolmes commented 3 years ago

This is working and good to merge!

loony-bean commented 3 years ago

Thanks @TDHolmes!