Fix plural words for Emoji and Confetti

loonywizard / js-confetti

JS Confetti library that supports emojis 🦄 🎉 ⚡️

https://loonywizard.github.io/js-confetti/

MIT License

1.13k stars 48 forks source link

Fix plural words for Emoji and Confetti #24

Closed a-trost closed 3 years ago

a-trost commented 3 years ago

Hey @loonywizard this looks like a super fun library, and I'm gonna take it for a spin on a project I have.

One thing I've noticed is the spelling of emojis as emojies which I think should be marked as incorrect.

It seems that emojis is the accepted plural of emoji.

Also confetti is already plural, and wouldn't be pluralized as confetties in properties like confettiesNumber. That would still be confettiNumber.

loonywizard commented 3 years ago

Hi @a-trost, thanks a lot! I'll fix this soon, plural forms here are definitely wrong

loonywizard commented 3 years ago

merged https://github.com/loonywizard/js-confetti/pull/26