search

loonywizard / js-confetti

JS Confetti library that supports emojis 🦄 🎉 ⚡️
https://loonywizard.github.io/js-confetti/
MIT License
1.13k stars 48 forks source link

Moving react and react-dom into devDependencies. #41

Closed halilb closed 2 years ago

halilb commented 2 years ago

Thanks for the library @loonywizard!

I have a project without react. And I noticed that react and react-dom appeared in my package-lock.json file after installing js-confetti. The library source code actually doesn't depend on those packages. I believe they are in the dependencies list because of the demo homepage.

So I moved them into devDependencies. They won't end up in end users' dependency tree this way, and the site should be working fine after this change.

loonywizard commented 2 years ago

@halilb thanks a lot for your contribution!

I was thinking whether react should be in dependencies or devDependencies, it seems devDeps is a better place for react

I will publish 0.10.1 version with your changes