looooo / FreeCAD

My FreeCAD Fork
Other
3 stars 0 forks source link

add generic solver #1

Open looooo opened 7 years ago

looooo commented 7 years ago

TODO

proposal

joha2 commented 7 years ago

Looks correct. Maybe there is some other registering instance? Maybe wernerh could help us in the forum?

looooo commented 7 years ago

ahh, the console report errors in the console. So this works. But the file in the fem-wb is sending the messages to the reportview.

Docs of OutputStdout

* Python class for redirection of stdout to FreeCAD's output
 * console window. This allows to report all Python output to
 * the output window which simplifies debugging scripts.

so the isatty function must implemented for these classes too.

joha2 commented 7 years ago

Sorry, I don't get it. For which classes you also have to implement the isatty() method?

looooo commented 7 years ago

sorry for my unclear message. here: src/Gui/PythonConsolePy L94 and L116

joha2 commented 7 years ago

Did it work? :-)

looooo commented 7 years ago

My workflow with conda is a bit time intensive. At the moment there is no way for me to build only changed files for freecad. So I have to compile the full source all the time something changed in c++. As I forgot some things (like adding files to CMakeList.txt) I had to build several times. This is a bit frustrating. So I had no chance to try the fix yet, but I am pretty sure the additional isatty function will solve the issue. If I have time I will try to understand your docker workflow. Maybe this is the better approach to develop stuff for FreeCAD.

joha2 commented 7 years ago

Yeah sounds frustrating! The docker workflow is also rather complicated I think. This is because you only have this sandbox and you have to mess around with access permission a lot. At the moment the description is more or less "hingerotzt", so maybe it is not that useful. But If you have problems from this description, we could still improve it. Now I have the git problem again: So maybe I will as a first step just clone your source and try to compile it. :-)

looooo commented 7 years ago

instead of cloning:

git fetch looooo
git checkout looooo/genericSolver
git checkout -b cloneOfGenericSolver

Btw. There is another error with the added files. https://github.com/looooo/FreeCAD/blob/genericSolver/src/Mod/Fem/CMakeLists.txt#L106#L109 these lines should be removed.