search

looooo / freecad.gears

a gear module for freecad
GNU General Public License v3.0
237 stars 95 forks source link

[Gears] Remove use of deepcopy due to the change in FreeCAD core code #137

Closed Syres916 closed 7 months ago

Syres916 commented 7 months ago

See https://github.com/FreeCAD/FreeCAD/issues/11514

Tested with :

OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.20.2.29697 (Git)
Build type: Release
Branch: releases/FreeCAD-0-20
Hash: 5fe2a07044a1523c79ca94b1b124c3a3571708d6
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.3.0
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * Silk 0.1.3
  * Defeaturing 1.2.0
  * CurvedShapes 1.0.4
  * freecad.gears 1.0.0
  * Curves 0.6.13
  * Help 1.0.3
  * fasteners 0.4.56
  * sheetmetal 0.3.0
OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.2.33772 (Git)
Build type: Release
Branch: releases/FreeCAD-0-21
Hash: abf147e2112c1ded4918435d2540f02be8a1ffc0
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * Silk 0.1.3
  * Defeaturing 1.2.0
  * CurvedShapes 1.0.4
  * freecad.gears 1.0.0
  * Curves 0.6.13
  * Help 1.0.3
  * fasteners 0.4.56
  * sheetmetal 0.3.0
OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.35195 (Git)
Build type: Release
Branch: main
Hash: ac4a8780521fef72569498426c66f67abab77e1d
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * Silk 0.1.3
  * Defeaturing 1.2.0
  * CurvedShapes 1.0.4
  * freecad.gears 1.0.0
  * Curves 0.6.13
  * Help 1.0.3
  * fasteners 0.4.56
  * sheetmetal 0.3.0
looooo commented 7 months ago

Thanks @Syres916 , I am fine with these changes. Is this ready to be merged?

Syres916 commented 7 months ago

Yes it is ready to be merged, thanks.