Rename GUI commands to follow FreeCAD format

looooo / freecad.gears

a gear module for freecad

GNU General Public License v3.0

252 stars 95 forks source link

Rename GUI commands to follow FreeCAD format #153

Closed hasecilu closed 10 hours ago

hasecilu commented 7 months ago

Making this change will enable users to use What's this? command on FCGear commands and get the correct Wiki article opened.
Add missing comma that provoked error.

I make the test saving a file prior the change and opening after it, no problems, anyway someone test it. Since no changes on the names of classes that create the objects were made I think is safe to merge.

Fix #151, #154

looooo commented 7 months ago

Can we change the workbench name to freecad.gears, maybe doing this also for the wiki.

hasecilu commented 7 months ago

I think it's doable, but just admins can do it. Regarding the capitalization, to make it "fit" to the other pages what do you think about FreeCADGears for the workbench and commands would be like FreeCADGears_InvoluteGear?

looooo commented 7 months ago

is this backward compatible?

hasecilu commented 7 months ago

Edit 2024-09-10:

is this backward compatible?

Yes, because the classes that create the objects are not changed there is no problems

I made some test files before the renaming and opening them after the change seems to not affect them. As long as no properties are modified it's safe renaming commands. Even for scripting the Create* classes are used directly the toolbar commands are not involved.

hasecilu commented 6 months ago

I have just made this same changes for Fasteners WB and all seems to work fine there also. Do you prefer FreeCADGears_ instead of FCGear_?