loop8ack / ExtensionPackTools

Import and export lists of Visual Studio extensions.
Other
78 stars 15 forks source link

Import dialog Select/deselect all check box also deselects greyed-out checkboxes #35

Closed astrohart closed 3 years ago

astrohart commented 3 years ago

To reproduce this issue, first, obtain v0.6.66 or higher of this extension.

Then, click the Extensions menu in VS, point to Import and Export Extensions, and then click Import Extensions, as shown:

image

Next, browse to select a *.vsext file, and then click Open:

image

The Import Extension dialog box appears.

image

As shown, there are some grayed-out extensions (as they are already installed). Clicking the Select/deselect all check box changes the state of these grayed-out checkboxes as well as the enabled (non-grayed-out) checkboxes.

In my mind, this is inconsistent UI/UX. The behavior should be to always leave the grayed-out check boxes unchecked due to their indicating extensions that are not suitable for import since they're already installed.

To reproduce the issue, click the Select/deselect all check box several times (e.g., 2-3 times) to see the behavior. In Win Desktop UI/UX, grayed-out checkboxes' states should not change at all. And, since, in this context, grayed-out checkboxes denote extensions that will NOT be imported, they should remain unchecked throughout the lifetime of the dialog box.

astrohart commented 3 years ago

See PR #36.