loop8ack / ExtensionPackTools

Import and export lists of Visual Studio extensions.
Other
78 stars 15 forks source link

Fixed #35. #36

Closed astrohart closed 3 years ago

astrohart commented 3 years ago
  1. Updated docs.
  2. First, the method starts asking if there are any disabled check boxes in the list.
    • If so, then it will forcibly clear the check marks in all such boxes, and then return.
    • Otherwise, it will only allow the Select/Deselect All checkbox to affect the states of only the enabled (i.e., grayed-in) check boxes.

This is necessary for two reasons:

  1. In the "Import" modality of doing things, some extensions which might happen to be listed in the *.vsext file, might already be installed in Visual Studio. Therefore, it is necessary to gray out their check boxes but still list them as already installed. It is not appropriate for the Select/Deselect All button to affect these check boxes, since they list extensions which are not relevant to the action being taken by the user (they are just listed for informational purposes only).

  2. As the UI stands, a check mark in an extension's check box indicates that it is to be included in the collection of extensions that the current action (i.e., Import or Export) will affect. Since grayed-out check boxes only show up for the Import side, and since the graying out means these extensions are already installed (and thus are not to be imported), it makes sense to me to force their check boxes to never have a check mark. This way it is clear to the user that "these extensions aren't part of the Import action set."

astrohart commented 3 years ago

Fixed #36 as well.

astrohart commented 3 years ago

Make the "OK" button more descriptive than just saying Install../Select. This is to make the action that will be taken upon clicking the button to be perfectly clear to the user.

madskristensen commented 3 years ago

Thanks