Two new themes, theme-docker-light and theme-docker-dark, added in fi…

loopDelicious / docker-extension

Docker Desktop extension using Postman's Newman to run collections

22 stars 11 forks source link

Two new themes, theme-docker-light and theme-docker-dark, added in fi… #10

Closed AniqJaved closed 2 years ago

AniqJaved commented 2 years ago

…le.hbs

AniqJaved commented 2 years ago

✅I have added two themes which are following docker color palette. 🚀In case of further modifications, kindly let me know.

AniqJaved commented 2 years ago

Sure👍

AniqJaved commented 2 years ago

@loopDelicious I have added changes🚀 to the references of the classname.

loopDelicious commented 2 years ago

@AniqJaved

I don't see the changes have cascaded. Can you please take a screenshot of the HTML reporter with the new docker theme in effect? I added a missing step in the README instructions about building the HTML reporter docker image, in case that was a hangup.
Can you remove the unused CSS? Or revert the additions so the docker theme resides in the original classnames?

AniqJaved commented 2 years ago

Hello @loopDelicious, so i encountered this error

App.tsx:166 Uncaught TypeError: Cannot read properties of undefined (reading 'length') at App (App.tsx:166:1)

I wanted to ask that what this line of code is supposed to do: -r htmlextra --reporter-htmlextra-template /file.hbs; cat ./newman/*.html"`,

loopDelicious commented 2 years ago

@AniqJaved that line applies the custom reporter defined in the file.hbs handlebars template, and then displays the HTML results of the collection run.

If you're having trouble setting it up locally, please let me know what you're stuck on. Since I might be missing a step in my documentation.

AniqJaved commented 2 years ago

The error that I am having is:

App.tsx:166 Uncaught TypeError: Cannot read properties of undefined (reading 'length') at App (App.tsx:166:1)

Also there is no display at the docker desktop as I add api key:

https://user-images.githubusercontent.com/86469982/197364184-d4e9f35c-690b-4817-8d35-5d59590755c6.mp4

loopDelicious commented 2 years ago

@AniqJaved I merged a different pull request, and made some minor updates. Can you please pull the latest code from GitHub? And then run make && make update to update your local extension? Let me know if that's works!

AniqJaved commented 2 years ago

Nopes, still facing the same problem

https://user-images.githubusercontent.com/86469982/197379893-abc8d67b-dba2-4365-ad74-1626c683d7de.mp4

loopDelicious commented 2 years ago

@AniqJaved can you double check to make sure you updated to the latest extension? App.tsx should contain a new const called apiKeyInContext. I wonder if you need to re-run all the setup scripts described in the Readme.

And does the collection you're running include at least 1 request?

AniqJaved commented 2 years ago

Yep it got working thanks @loopDelicious. I have added a PR in that regard. Also I have made a short video for the functionality check.

https://user-images.githubusercontent.com/86469982/197438735-2457c88c-42d3-47be-8f45-bedd58afa90d.mp4

loopDelicious commented 2 years ago

Addressed in #13