loopandlearn / LoopFollow

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
108 stars 633 forks source link

Setting ‘show days back’ value beyond available data causes BG feed to disconnect #167

Closed chintzboy closed 1 month ago

chintzboy commented 2 years ago

Loop Follow was installed on an iPad about 16 hours ago. When I increased the ‘show days back’ value to 3, the Dexcom data feed stopped working. When I reduced it to 1, the blood glucose values resumed immediately. I don’t know if this is a bug or a feature.

jonfawcett commented 2 years ago

This only works with nightscout data. The bug is that the option is still displayed when you only have dexcom details entered.

chintzboy commented 2 years ago

In my case, I have both the nightscout credentials, which continued to work when the BG dropped, and the Dexcom credentials entered.

Having re-read your comment just a second ago, I'm editing this, I think what you're saying is if I have both sets of credentials entered I can't use the feature?

jonfawcett commented 2 years ago

That’s unusual. It could have been a more recent change that broke something in this then. But I’m basically at a stop on LF changes unless it’s a deal breaker crash because I’m focused on a full re-write for the next version.

chintzboy commented 2 years ago

Sounds good to me. It's a great piece of software! I'm eager to see the next version.

bjorkert commented 7 months ago

Sounds good to me. It's a great piece of software! I'm eager to see the next version.

Hi, @chintzboy do you know if this still is an issue?

marionbarker commented 1 month ago

Pretty sure this was fixed with recent changes to the code. I don't have the PR handy but closing anyway.