loopandlearn / LoopFollow

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
104 stars 545 forks source link

Future carbs no longer showing in LoopFollow 2.0.0.1 #242

Closed milleniumfalcon900 closed 8 months ago

milleniumfalcon900 commented 10 months ago

The update to LoopFollow 2.0.0.1 seems to have prevented future carbs showing in LoopFollow. When my son boluses 15 minutes in advance the carbs don't show, although they are there in Nightscout. Has anyone else experienced this? LoopFollow built with Xcode and running on iOS 17.0.3

Thanks for your continued hard work.

IMG_2706 IMG_2705 IMG_2704

marionbarker commented 10 months ago

I tested and confirmed future carbs do not show up. Thanks for the report.

bjorkert commented 10 months ago

I'm curious about how far in advance it would be reasonable for LoopFollow to check for future carbs. What do you think?

milleniumfalcon900 commented 10 months ago

I know from the FB group that some people schedule their carbs well ahead of time. We don’t usually do more than 20 minutes. My view is that it’s a bit risky, you never know what might happen that might prevent someone from eating at a scheduled time, even if it’s a child at school.

I guess the counter argument is for people who schedule extra carbs to deal with really long acting meals they’ve already eaten maybe 4 hours out so earlier. I guess if you’re looking at that scenario then maybe 6 hours might be a sensible time limit.

Is there a consequence of loop follow looking really far ahead?

bjorkert commented 10 months ago

We can try 6 hours.

The filtering out future treatments was due to Loop dev added sensor starts in year 2159, messing things up.