search

loopandlearn / LoopFollow

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
106 stars 569 forks source link

Implement Display of Manual BG Values and Standardize Unit Conversion #288

Closed bjorkert closed 5 months ago

bjorkert commented 5 months ago

This PR introduces the display of manual BG values from Loop and Apple Health in the app's graphs. It also ensures that manual BG check entries from Nightscout using mmol are correctly shown. Additionally, the PR standardizes mmol/L <-> mg/dL conversions throughout the application using centralized constants for improved consistency and maintainability.

marionbarker commented 5 months ago

Code review looks good with possible suggestion to later modify the capitalization for some variables: in the US it is mg/dL not mg/Dl. The actual name is not that important, so merging as is.

Confirmed that units display as expected and manual glucose entry (from NS careportal) shows up on LoopFollow display.