loopandlearn / LoopFollow

A general Follow app for parents of T1D Loop Users
GNU Affero General Public License v3.0
99 stars 494 forks source link

Transparent tabbar if you navigate from main screen to settings view #299

Closed petwall closed 3 weeks ago

petwall commented 1 month ago

If you go directly to the settings view from the main screen, you will get a transparent tabbar like the attached screenshot: image

However, if first going to 'Alarms' it renders correctly.

It looks like it's an unnecessary UIScrollView in the Main.storyboard, since you are using Eureka, it will take care of that automatically.

Just removing this subview makes everything work as it should:

diff --git a/LoopFollow/Application/Base.lproj/Main.storyboard b/LoopFollow/Application/Base.lproj/Main.storyboard
index 9136996..16b59b8 100644
--- a/LoopFollow/Application/Base.lproj/Main.storyboard
+++ b/LoopFollow/Application/Base.lproj/Main.storyboard
@@ -529,14 +529,6 @@
                     <view key="view" contentMode="scaleToFill" id="ljg-dW-5uR">
                         <rect key="frame" x="0.0" y="0.0" width="414" height="896"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
-                        <subviews>
-                            <scrollView clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="scaleToFill" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="6gS-Ff-qPd">
-                                <rect key="frame" x="0.0" y="44" width="414" height="769"/>
-                                <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
-                                <viewLayoutGuide key="contentLayoutGuide" id="1wh-Gg-Auv"/>
-                                <viewLayoutGuide key="frameLayoutGuide" id="lqA-iJ-wdZ"/>
-                            </scrollView>
-                        </subviews>
                         <viewLayoutGuide key="safeArea" id="aVb-ap-Pwt"/>
                         <color key="backgroundColor" systemColor="systemBackgroundColor"/>
                     </view>

Thanks for an amazing app!

bjorkert commented 3 weeks ago

Thank you, I have now included this change in the branch I am working on right now.