search

loopbackio / loopback-connector-cassandra

Cassandra connector for the LoopBack framework.
Other
13 stars 22 forks source link

fix issue where settings.contactPoints not used #70

Closed hliu9 closed 6 years ago

hliu9 commented 6 years ago

Description

Use settings parameter contactPoints for cassandra client options if provided.

Related issues

If settings.contactPoints has been provided, the clientOptions is initialized without any hosts.

Checklist

hliu9 commented 6 years ago

related https://github.com/strongloop/loopback-connector-cassandra/pull/69

image the constributor check does not seem to reflect on latest... (i re-opened the PR in hope it would get updated)

this was a fairly trivial change, ut was not modified. please suggest otherwise

virkt25 commented 6 years ago

cc: @rmg -- Can you help with the clahub

rmg commented 6 years ago

@hliu9 the commits are being attributed to @haiyiliu9 which is a different account than the one you signed the CLA with.

What you probably want to do is update your git config for this repo (git config user.email ...) and then re-write the commits on your branch.

Note that simply updating your config and rebasing your branch, without further action, would only update the Committer for the commits, not the Author, and it is the Author that is the important one to change.

There are many many different ways to do it depending on your familiarity/comfort with git. There's a GitHub Help article that might be useful: https://help.github.com/articles/changing-author-info/

hliu9 commented 6 years ago

@rmg thank you for that. I've opened a new PR with the correct author name. https://github.com/strongloop/loopback-connector-cassandra/pull/71