loopbackio / loopback-connector-cassandra

Cassandra connector for the LoopBack framework.
Other
13 stars 22 forks source link

Run shared tests from both v3 and v4 of juggler #76

Closed bajtos closed 5 years ago

bajtos commented 5 years ago

At the moment, our connectors are installing juggler 3.x to run the test suite. When we make a change to juggler@3, cis-jenkins detects downstream dependency and triggers CI build of connectors with the modified juggler version. When we make a change to juggler's master, no downstream builds are triggered.

In the past, we were maintaining multiple branches to test connectors against different juggler versions. E.g. loopback-2.x containing code from "master" but installing juggler 2.x for testing. This is rather impractical, because we don't have bandwidth to update those other branches with changes made to master.

Let's rework the connector test setup to execute tests from both juggler versions 3.x and 4.x, as we are already doing in other connector repositories.

The reference pull request to draw inspiration from: strongloop/loopback-connector-mongodb#519. See also strongloop/loopback-connector-postgresql#376.

shenghu commented 5 years ago

@bajtos is this urgent? I can take this one.

bajtos commented 5 years ago

@shenghu not urgent at all. It would be great if you can contribute the changes yourself!

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bajtos commented 5 years ago

@stale not stale yet

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.