Fix/test inheritance - Githubissues

loopbackio / loopback-connector-cloudant

LoopBack Connector for IBM Cloudant

Other

19 stars 21 forks source link

Fix/test inheritance #161

Closed virkt25 closed 7 years ago

virkt25 commented 7 years ago

Description

Related issues

None

Checklist

[x] New tests added or existing tests modified to cover all changes
[x] Code conforms with the style guide

connect to https://github.com/strongloop-internal/scrum-apex/issues/264

virkt25 commented 7 years ago

connected to https://github.com/strongloop-internal/scrum-apex/issues/264

virkt25 commented 7 years ago

@slnode test please

virkt25 commented 7 years ago

@kjdelisle Yes it's both a devDep and dep. I was just trying to see if that had anything to do with /test folder in the couchdb2 package not being installed.

jannyHou commented 7 years ago

One failure:

  1) cloudant replace.test - imported from couchdb2 replaceById replace should remove model view properties (i.e loopback__model__name):
     Uncaught AssertionError: expected 'Product' to not exist

Has been fixed in couchdb https://github.com/strongloop/loopback-connector-couchdb2/pull/16 Will pass after we land the function inheritance PR https://github.com/strongloop/loopback-connector-cloudant/pull/163, but that PR is blocked by this one. So let's merge this one first.

dhmlau commented 7 years ago

Force merge because of the circular dependencies.