search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
79 stars 56 forks source link

Data source was not initialized properly for tests #1

Closed srisub closed 9 years ago

sam-github commented 9 years ago

test please

pulkitsinghal commented 9 years ago

@sam-github - Its the test itself, which has been fixed in the PR.

This seems like a situation where tests were working fine on my laptop but when someone else cloned the project, they ran into an issue where the lookup of elasticsearch by the datasource ... incorrectly leads to instantiation of the elasticsearch driver library instead of the elasticsearch connector library!

Here are the logs that other folks tend to see when this confusion occurs:

Looks like you are expecting the previous "elasticsearch" module.
It is now the "es" module. To create a client with this module use 
`new es.Client(params)`.

@srisub - Thanks for the patch, I see now that you've initialized the connector a bit differently for tests to avoid such an issue.

rmg commented 9 years ago

@pulkitsinghal Sam was trying to tell Jenkins to test the PR, but this project is not built on our Jenkins server.