search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
78 stars 57 forks source link

Specify the version of http-aws-es needed #105

Closed brewdium closed 6 years ago

brewdium commented 6 years ago

http-aws-es has had quite a few updates now and it does not support passing through credentials in the same manner. This could be remedied by simply creating a AWS.Config object to pass in as a parameter instead of the credentials however just updating the readme should also make it functional.

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

aquid commented 6 years ago

@pulkitsinghal Please look into this.

pulkitsinghal commented 6 years ago

Thank You for contributing to the README @spazworm

pulkitsinghal commented 6 years ago

@dtomasi - Bit late to ask but still, any comments? You had contributed this feature back then: https://github.com/strongloop-community/loopback-connector-elastic-search/commit/35c2d84da33fecd78e5416c9d236dfaa6561f7e3

dtomasi commented 6 years ago

@pulkitsinghal Had no notice about the changes to http-aws-es, sorry. We are using a fixed version in our package.json. Happy @spazworm found it.