search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
79 stars 56 forks source link

Use settings.type for name conversion #32

Closed lukewendling closed 8 years ago

lukewendling commented 8 years ago

fix #31 quickly and dirty-ly

slnode commented 8 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

endjay commented 8 years ago

great i need this too , is this all ready patch and update on npm package ?

lukewendling commented 8 years ago

@endjay I don't know but I'm using my github fork, specified in package.json

pulkitsinghal commented 8 years ago

@lukewendling and @endjay - thanks for the wake up call, I published version 1.0.3 with these changes to NPM now

pulkitsinghal commented 8 years ago

@lukewendling - I don't think I heard back from you about my feedback in the gitter chat room back when:

Nov 18 2015 14:20 @lukewendling - not sure the fix you made thus far is the right one ... did it actually work for you? the way you have it, i think you'll end up with one custom type for all models instead of one custom type per model

lukewendling commented 8 years ago

@pulkitsinghal this was definitely a quick fix. it allows to create an ES connector for each specified type. thus one config section in datasources.json for each type. not ideal. a better solution perhaps is a mapping from model name to ES type, perhaps in datasources.json.