search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
79 stars 56 forks source link

Change the filter 'nor' operator on the loopback 'neq' analogue #35

Open angfal opened 8 years ago

angfal commented 8 years ago

By documentation (https://docs.strongloop.com/display/public/LB/Where+filter), loopback doesn't have 'nor' operator.

I think, the 'nor' operator should be changed on 'neq'. It will more conform to loopback api

pulkitsinghal commented 8 years ago

I admit that this may sound a bit ignorant, but could you help point out for me with a quick sample snippet, how can nor can be used with this connector right now?

And where do you see the code for it sitting? I don't remember writing it explicitly but its been several months and mind is all over the place.

angfal commented 8 years ago

I learn your code more carefully. It'll be cool if you just add 'neq' function support. I added a pull request to my issue. I think, it just only needs some tests

pulkitsinghal commented 8 years ago

I don't have an ES instance or a meaningful dataset that I can point it to for testing right now ... thinking ...