Support Signed Requests for AWS Elasticsearch-Service

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch

MIT License

78 stars 56 forks source link

Support Signed Requests for AWS Elasticsearch-Service #55

Closed dtomasi closed 7 years ago

dtomasi commented 7 years ago

I´m using AWS Elasticsearch-Service and wasn´t able to connect. So I had to sign the requests. Thinking this could also be interesting for someone else who uses AWS.

Best regards Dominik

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

pulkitsinghal commented 7 years ago

Looks simple enough. Would it be more prudent to somehow make the addition of the amazon dependency documented for those who want this rather than increasing the size of installed dependencies by default for everyone?

dtomasi commented 7 years ago

I agree! It´s really not necessary to increase the number of dependencies.

pulkitsinghal commented 7 years ago

@dtomasi - thank you for this:

changed the base branch to strongloop-community:develop from strongloop-community:master