search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
78 stars 56 forks source link

Include filter issue fixed #71

Closed aquid closed 7 years ago

aquid commented 7 years ago

Include filter was not working. There was a discussion about implementation of include filter in issue #28 which is still pending. I have implemented the minimum workflow to make include filter work until we optimize it for better performance.

Right now the filter works with loopback internal include method implementation and the connector just passes right arguments to loopback method to make it work.

pulkitsinghal commented 7 years ago

nicely written tests

i'm researching other aspects of include filter like pagination now ... nope ... skip and limit filters are separate filters for pagination ... your implementation of include has nothing to do with them ... ok my head is clear

you tested: {include: 'posts'} and {include: {relation: 'posts', scope: {fields : ['title']}}

but there are others that will need to be tested/supported: https://loopback.io/doc/en/lb2/Include-filter.html#examples

good enough for now I suppose, thank you and good job Aquid

aquid commented 7 years ago

28