search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
78 stars 56 forks source link

"and" & "inq" loopback filter #73

Closed Biax2099 closed 7 years ago

Biax2099 commented 7 years ago

Hello, i found this comment // TODO: or Logical OR operator // TODO: and Logical AND operator // {"where":{"and":[{"id":{"inq":["1","2","3","4"]}},{"vip":true}]}} in lib/esConnector.js.

I would ask you, if will be developed in few time and if i can help in some way.

Thank you so much!

pulkitsinghal commented 7 years ago

@Biax2099 - The community would certainly welcome any contributions you can make.

Usually contributors fork & clone the connector and then get used to running the tests with or without docker. Afterwards they dive into the code to get desired results and submit a PR with a few new tests of their own, proving that the functionality works and that nothing from the past is broken.

The submitted PR is reviewed, some changes may occur and then merge happens. Quickly thereafter a release to npmjs is performed so that the community can benefit and the contributors are given credit in the changelog.

While I or @aquid could make this change ourselves in 2-4 days. We are way too swamped with our day job to do so anytime soon.

aquid commented 7 years ago

Resolved...

Biax2099 commented 7 years ago

thanks @pulkitsinghal, @aquid