search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
79 stars 55 forks source link

es 5.0 compatibility #80

Closed wolfgang-s closed 7 years ago

wolfgang-s commented 7 years ago

Only little changes were necessary.

I needed to upgrade npm dependencies, so do a npm install. Added a ES 5 instance to docker compose.

All tests pass.

Might conflict a little bit with my other PR. I needed to add a refresh: true at destroyAll, which is already in the other PR.

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

wolfgang-s commented 7 years ago

Any updates? Or questions?

Should I create another PR for the develop branch and resolve conflict?

aquid commented 7 years ago

@wolfgang-s I have my hands full as of now so if you could allow me some time I can surely review this and let you know.

@pulkitsinghal ??

wolfgang-s commented 7 years ago

please close this one, i submitted a new one for the develop branch with newest version.