search

loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch
MIT License
78 stars 56 forks source link

added options to function signatures #82

Closed wolfgang-s closed 4 years ago

wolfgang-s commented 7 years ago

This is only the change of the functions. I did not use the options object for now, because there would be conflicts with my other PR then. As soon as everything is merged I can create another PR.

Is this enough?

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

aquid commented 7 years ago

@wolfgang-s

This is only the change of the functions.

NOT that useful

As soon as everything is merged I can create another PR.

It's better to submit a new PR with complete feature. I would suggest making changes for both options and refresh parameter would be much helpful.

wolfgang-s commented 7 years ago

@aquid Since now the refresh true is merged I will do it now!