loopbackio / loopback-connector-elastic-search

Strongloop Loopback connector for Elasticsearch

MIT License

78 stars 56 forks source link

Param criteria in buildFilter should be of type Object #92

Closed kamal0808 closed 7 years ago

kamal0808 commented 7 years ago

91

I couldn't find any tests to check and validate argument types of functions. Also, chai doesn't support this feature. But I found this : https://github.com/theblacksmith/chai-param that does it. May be of some use?

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."