search

loopbackio / loopback-connector-mssql

LoopBack connector for Microsoft SQL Server
http://loopback.io/doc/en/lb3/SQL-Server-connector.html
Other
52 stars 84 forks source link

Update migration.js #228

Closed ataft closed 4 years ago

ataft commented 4 years ago

Execute alterTable statements in order

slnode commented 4 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

dhmlau commented 4 years ago

@slnode test please

ataft commented 4 years ago

Any updates on this?

agnes512 commented 4 years ago

Could you add tests for the change? I think https://github.com/strongloop/loopback-connector-mssql/blob/master/test/autoupdate.test.js might be a good place 😄 thanks!

ataft commented 4 years ago

The current test already covers this PR because it does an automigrate (create the table) on line 135 and then an autoupdate on line 155, which will call alterTable. BTW, this test should be failing intermittently, but given that the order is random it'd be hard to catch.

agnes512 commented 4 years ago

@slnode test please

jannyHou commented 4 years ago

@slnode test please

agnes512 commented 4 years ago

@slnode test please

jannyHou commented 4 years ago

dropping node 8 in https://github.com/strongloop/loopback-connector-mssql/pull/230, hope it fixes the error

jannyHou commented 4 years ago

@slnode test please

jannyHou commented 4 years ago

rebased the PR, let me trigger a new build and merge

jannyHou commented 4 years ago

merged 🎉 thank you @ataft for the contribution again!