search

loopbackio / loopback-connector-oracle

Connect Loopback to Oracle
http://loopback.io/doc/en/lb3/Oracle-connector.html
Other
28 stars 30 forks source link

Upgrade to oracledb 2.x #149

Closed raymondfeng closed 6 years ago

raymondfeng commented 6 years ago

Description

See https://github.com/oracle/node-oracledb/

Related issues

Checklist

raymondfeng commented 6 years ago

@kjdelisle If you look at the configuration name changes, it's not breaking. We still consider prefetchRows and maxRows. The connector behavior/apis do not change either. We could release it as new minor.

kjdelisle commented 6 years ago

@raymondfeng I guess it's technically not a breaking change if the default value for maxRows is a way of uncapping the rowSize of a query.

dhmlau commented 6 years ago

@raymondfeng , still in plan to land this PR?

raymondfeng commented 6 years ago

@dhmlau Yes. But the prebuilt oracle driver is still half baked and it cannot fallback to local gyp compilation. I'll follow up.

cjbj commented 6 years ago

Re upgrading: this has some info: https://blogs.oracle.com/opal/node-oracledb-v2-query-methods-and-fetch-tuning

dhmlau commented 6 years ago

@slnode test please

joostdebruijn commented 6 years ago

Is there something I can do to help moving this PR to master?

Frank683 commented 6 years ago

Dear @raymondfeng

Is there any concrete timeline we can expect loopback with oracle database connector to work on node >= 8.0? Or is there at least any workaround (windows and linux) which we can use in the meanwhile?

Regards, Frank

joostdebruijn commented 6 years ago

@Frank683 See #152, maybe that conversation helps? I have the connector working on Node 10 at this moment. However, this PR should land and I'm willing to make this work, however nobody is responding here. 😞

Frank683 commented 6 years ago

@joostdebruijn I have seen #152 before. It looks like some manual tweaking is required to get it to work. Since it must also run on our CI server in an automated process from scratch this doesn't seem to be an alternative unfortunately.

cjbj commented 6 years ago

On the topic of Node 10, also see https://github.com/oracle/node-oracledb/issues/901. I don't know whether the queryStream fix which will be in 2.3.0 impacts loopback.

raymondfeng commented 6 years ago

Released as loopback-connector-oracle@4.0.0