loopbackio / loopback-connector-oracle

Connect Loopback to Oracle
http://loopback.io/doc/en/lb3/Oracle-connector.html
Other
28 stars 30 forks source link

Added the connection property "_enableStats" #161

Closed ericalves closed 5 years ago

ericalves commented 6 years ago

Added the connection property "_enableStats".

Added the properties "_enableStats" of the oracledb settings in the validation of properties accepted by the connector.

We had problems with our application and we needed to see the connection and connection pool statuses, but it was not possible because the "_enableStats" property was not mapped.

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

raymondfeng commented 6 years ago

@ericalves Please sign CLA - https://cla.strongloop.com/agreements/strongloop/loopback-connector-oracle

raymondfeng commented 6 years ago

@ericalves Please also amend the commit log:

**************************************************
**
**  Linting commit logs
**
**  1 problems found:
**    d6f6e83 - Added the properties "_enableStats" of the oracledb: First line should be 50 characters or less (saw 119)
**
**************************************************
ericalves commented 6 years ago

Hi! I do not usually use Jenkins. I have adjusted the text of my commit. How should I proceed?

raymondfeng commented 6 years ago

See https://help.github.com/articles/changing-a-commit-message/

ericalves commented 6 years ago

What i need to do now?

raymondfeng commented 6 years ago

I'm seeing 3 commits in the PR. Usually, we squash them into one single commit with the correct message.

When you work on a PR with a simple fix, you can always amend the commit and force push it back. This way, only a single commit is in he PR.

raymondfeng commented 6 years ago

@ericalves I fixed your commits.

raymondfeng commented 6 years ago

ok to test

ericalves commented 6 years ago

Thanks @raymondfeng for you patience. I will be can more carefull in the next commits.

raymondfeng commented 6 years ago

ok to test

ericalves commented 5 years ago

Hi! Someone can help me to approve this pr? thanks!