Closed ericalves closed 5 years ago
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."
@ericalves Please sign CLA - https://cla.strongloop.com/agreements/strongloop/loopback-connector-oracle
@ericalves Please also amend the commit log:
**************************************************
**
** Linting commit logs
**
** 1 problems found:
** d6f6e83 - Added the properties "_enableStats" of the oracledb: First line should be 50 characters or less (saw 119)
**
**************************************************
Hi! I do not usually use Jenkins. I have adjusted the text of my commit. How should I proceed?
What i need to do now?
I'm seeing 3 commits in the PR. Usually, we squash them into one single commit with the correct message.
When you work on a PR with a simple fix, you can always amend the commit and force push it back. This way, only a single commit is in he PR.
@ericalves I fixed your commits.
ok to test
Thanks @raymondfeng for you patience. I will be can more carefull in the next commits.
ok to test
Hi! Someone can help me to approve this pr? thanks!
Added the connection property "_enableStats".
Added the properties "_enableStats" of the oracledb settings in the validation of properties accepted by the connector.
We had problems with our application and we needed to see the connection and connection pool statuses, but it was not possible because the "_enableStats" property was not mapped.