search

loopbackio / loopback-connector-oracle

Connect Loopback to Oracle
http://loopback.io/doc/en/lb3/Oracle-connector.html
Other
28 stars 30 forks source link

Make local tests pass #190

Closed hacksparrow closed 4 years ago

hacksparrow commented 5 years ago

Currently running source setup.sh and then npm test will result in the command left hanging.

It is caused by sath89/oracle-xe-11g being gone from Docker Hub. A good replacement is webdizz/oracle-xe-11g-sa.

Some things I noted while working on https://github.com/strongloop/loopback-connector-oracle/issues/183:

  1. Replace sath89/oracle-xe-11g with webdizz/oracle-xe-11g-sa or something similar.
  2. Hard-coded values in tests makes the use of custom username (schema) impossible. Remote and local usernames have to be the same or hard-coded values have to be replaced with configurable ones.
  3. The code in test/tables.sql has to be edited to make it work with the latest version of sqlplus, the client used by the local test setup.
  4. Use of UTC offset in the dateToOracle function was making tests fail on my machine. It looked like a timezone thing.
stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.