search

loopbackio / loopback-connector-redis

EXPERIMENTAL: Redis connector for LoopBack.
http://loopback.io/doc/en/lb2/Redis-connector.html
Other
36 stars 46 forks source link

Empty result returns error to use for 404 #32

Closed penguinpowernz closed 8 years ago

penguinpowernz commented 8 years ago

Previously this was giving an undefined error object, and an array like [{}] as the objects causing strange behaviour in libraries that we using this connector as the datasource.

slnode commented 8 years ago

Can one of the admins verify this patch?

slnode commented 8 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

jannyHou commented 8 years ago

@slnode test please

superkhau commented 8 years ago

Can you add some tests to verify your changes and prevent regressions in the future?

penguinpowernz commented 8 years ago

Added a couple of tests and fixed linter issues, check it out

superkhau commented 8 years ago

Link to PR with ESLint fix https://github.com/strongloop/loopback-connector-redis/pull/33

slnode commented 8 years ago

Can one of the admins verify this patch?

penguinpowernz commented 8 years ago

Sweet, how's it look now?

superkhau commented 8 years ago

Can you rebase with master to get the latest changes? I also added few more comments, we're almost there. ;) Mostly LGTM now.

penguinpowernz commented 8 years ago

Oh man I fucked it up... what kind of sourcery is this rebasing...

superkhau commented 8 years ago

@penguinpowernz Do you still have your local? Feel free to submit another PR with the correct changes. Ping me in the new PR and I can give you a hand with rebasing. ;)