search

loopbackio / loopback-connector-redis

EXPERIMENTAL: Redis connector for LoopBack.
http://loopback.io/doc/en/lb2/Redis-connector.html
Other
36 stars 46 forks source link

Fix for destroyAll #49

Closed gclyne closed 7 years ago

gclyne commented 7 years ago

Description

results was returning back [null] whenever this.all could not find an element matching the specified where clause. The source of where the [null] comes from is the npm redis module.

Related issues

https://github.com/strongloop-community/loopback-connector-redis/issues/38

gclyne commented 7 years ago

https://icodealot.com/get-multiple-redis-hashes-in-node-js/

superkhau commented 7 years ago

Can you add some tests to verify your changes and prevent regressions in the future?

superkhau commented 7 years ago

@slnode test please

superkhau commented 7 years ago

@slnode test please

superkhau commented 7 years ago

CI doesn't work in sl-community at all, landing this to unblock @gclyne

cc @bajtos @ritch We need to figure out CI strategy for community repos.

bajtos commented 7 years ago

@superkhau We need to figure out CI strategy for community repos.

I am proposing to use Travis CI. If Windows support is important, then add AppVeyor too (docs).

superkhau commented 7 years ago

@bajtos I 100% agree with you on the travis/appveyor strategy. Wish we could do it cross all repos. ;)